api: remove ApplyPolicy from Global #3231
Merged
+135
−151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ApplyPolicy field in the API Global structure was added as an equivalent to config.Global.ApplyPolicy used in file-based configuration. However, unlike file-based configuration, API-based configuration is designed to be set through multiple policy-related APIs such as AddPolicy, making ApplyPolicy inappropriate and unused in the API context. Therefore, it should be removed. Signed-off-by: FUJITA Tomonori <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ApplyPolicy field in the API Global structure was added as an equivalent to config.Global.ApplyPolicy used in file-based configuration. However, unlike file-based configuration, API-based configuration is designed to be set through multiple policy-related APIs such as AddPolicy, making ApplyPolicy inappropriate and unused in the API context. Therefore, it should be removed.