Skip to content

Conversation

@Marc-marc-marc
Copy link
Contributor

related to #2345

@Famlam
Copy link
Collaborator

Famlam commented Oct 11, 2024

I think that, using the example you provided: |altitude||{{tag|ele}} || tag ||
The capture groups would only be ["tag ||", None]
Instead of: ["altitude", "{{tag|ele}}", "tag", None]

Perhaps you can add a test case as well?

@Famlam
Copy link
Collaborator

Famlam commented Oct 14, 2024

The fix in #2358 should also resolve this issue and all other issues listed in #2345
I hope you don't mind that this PR would become obsolete in that case?

@Famlam
Copy link
Collaborator

Famlam commented Oct 20, 2024

Implemented via #2358

@Famlam Famlam closed this Oct 20, 2024
@Marc-marc-marc Marc-marc-marc deleted the patch-2 branch October 31, 2024 21:50
@Marc-marc-marc
Copy link
Contributor Author

I hope you don't mind that this PR would become obsolete in that case?

that's fine, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants