-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Trip Recording: Do Not Discard Filtered Points #22654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
The intent of my original suggestion was to mitigate the cases where users played with filters not knowing what they do, and then later lose valuable data. If we introduce one more setting to "optionally save all trackpoints", it only complicates the situation further, and this defies the purpose. |
Ok, I 've understood the intent as "give user an option to troubleshoot the track filtering, analyzing/comparing the full tracklog". That is - the idea is to save full tracklogs unconditionally, and then erase/purge them after some time period ? Can replace the "enable full tracklog saving" toggle switch with a "full tracklog storage duration" control (with an option to disable it). |
|
Some users asks for some kind of Google timeline |
|
Yes, thanks for the PR, anyway, @ezemskov !! Product Management decision needed how exactly it should be implemented, @vshcherb, I guess. I vote for a solution which is active by default and cannot easily be disabled by settings etc., because this is to primarily exactly mitigate setup mistakes users make in the (recording filter) settings. |
|
No worries I have some of following in mind to fix eventually - not sure of their status |
|
Yes, I have the same question sometimes: Is our 'Nice to have' tag to be taken in the literal sense ("would be a nice enhancement"), or is the stress rather with "not a must-have, so let's rather not have this complication" Probably we have examples of both... |
|
How about we simply put all filtered-out points in the file as commented out
|
Optionally save all trackpoints (including ones filtered according to the recoding plugin settings) in a separate .gpx file.
Full tracklog is saved in
/rec/unfiltered/<track_filename>_unfiltered.gpxSaving of full tracklogs is default disabled with a new boolean flag added into the plugin settings.
Note :
Automatic purge of full tracklogs after some time interval (as suggested in #22567) is not implemented.
Size of full tracklogs shouldn't be an issue with modern amount of storage (single point is ~250 bytes, 24hrs of unfiltered tracklog recorded at 1Hz is ~21Mb), even if it's explicitly enabled by the user.