Implement obd ble tmp #21907
Draft
Implement obd ble tmp #21907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-osm
reviewed
Feb 15, 2025
| LIVE(0x41), FREEZE(0x42), IDENTIFICATION(0x49) | ||
| } | ||
|
|
||
| private val sideDataToRemoveFromAnswer = arrayOf( |
| val connection = Obd2Connection(createTransport(), this) | ||
| try { | ||
| while (isConnected(connection)) { | ||
| var connectedScannerIsStopped = false |
Contributor
There was a problem hiding this comment.
Whole logics related to OBDResponse.STOPPED needs to be explained.
| } | ||
|
|
||
| private fun normalizeResponseString(fullCommand: String, response: String): String { | ||
| var response1 = response |
Contributor
There was a problem hiding this comment.
Do not use response1 like names
Comment on lines
+269
to
+275
| boolean isOBDDevice = device instanceof BLEOBDDevice; | ||
| if (isOBDDevice && vehicleMetricsPlugin != null || !isOBDDevice && externalSensorsPlugin != null) { | ||
| devices.put(device.getDeviceId(), device); | ||
| if (isOBDDevice && vehicleMetricsPlugin != null) { | ||
| vehicleMetricsPlugin.onBLEDeviceFound((BLEOBDDevice) device); | ||
| } | ||
| } |
Comment on lines
451
to
459
| if (device instanceof BLEOBDDevice) { | ||
| ((BLEOBDDevice) device).setDeviceReadyListener(new BLEOBDDevice.DeviceReadyListener() { | ||
| @Override | ||
| public void onDeviceReadyStateChange(boolean isReady) { | ||
| VehicleMetricsPlugin vehicleMetricsPlugin = PluginsHelper.getPlugin(VehicleMetricsPlugin.class); | ||
| vehicleMetricsPlugin.connectToDevice((BLEOBDDevice) device); | ||
| } | ||
| }); | ||
| } |
| } | ||
|
|
||
| @Nullable | ||
| protected List<BluetoothGattCharacteristic> cachedCharacteristics; |
Contributor
There was a problem hiding this comment.
Insert fields at top of the class!
| cachedCharacteristics?.let { | ||
| } | ||
| } | ||
| log.debug("Відправлено команду: $command; result $res") |
Contributor
There was a problem hiding this comment.
Write logs in english only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.