Skip to content

Conversation

@blacklion
Copy link

This is implementation of #12097.
This change doesn't have translations for two new strings.

@blacklion
Copy link
Author

I'm not sure about code style, sorry. I've tried to mimic existing one, for example I didn't use final fields as they are not used in "old" code.

Also, I'm not sure, should new non-translated strings be added as-is to non-English resources.

@vshcherb
Copy link
Member

See #12097

Lev Serebryakov added 2 commits July 15, 2021 13:38
This change doesn't have translations for two new strings.
De-register options listeners on plugin unload.
Lev Serebryakov and others added 2 commits July 18, 2021 16:55
Accept @comradekingu suggestion.

Co-authored-by: Allan Nordhøy <[email protected]>
Accept @comradekingu suggestion.

Co-authored-by: Allan Nordhøy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants