Skip to content

Upgrade librime-lua to latest commit #1834

Closed

Description

@Bambooin

Upgrade librime-lua to latest commit and clean the dependency.

Activity

  1. WhiredPlanck commented on Nov 28, 2025

    @WhiredPlanck
    Collaborator

    There are only 6 commit ahead of current checkouted commit and I don't see any notable change. Why mention this?

  2. Bambooin commented on Nov 29, 2025

    @Bambooin
    CollaboratorAuthor

    Is it possible to remove the librime-lua-deps dependency?

  3. WhiredPlanck commented on Nov 30, 2025

    @WhiredPlanck
    Collaborator

    Is it possible to remove the librime-lua-deps dependency?

    librime-lua-deps is a branch checked out from librime-lua that contains Lua source code, if we want to remove it, we need to add another submodule that point to Lua source code to build librime-lua.

  4. Bambooin commented on Nov 30, 2025

    @Bambooin
    CollaboratorAuthor

    https://www.lua.org/start.html

    To embed Lua into your C or C++ program, you'll need the Lua headers to compile your program and a Lua library to link with it. If you're getting a ready-made Lua package for your platform, you'll probably need the development package as well. Otherwise, just download Lua and add its source directory to your project.

    Cloud we replace the patch(patches/lua.patch) with this commit?
    lua/lua@9a3940

  5. WhiredPlanck commented on Nov 30, 2025

    @WhiredPlanck
    Collaborator

    https://www.lua.org/start.html

    To embed Lua into your C or C++ program, you'll need the Lua headers to compile your program and a Lua library to link with it. If you're getting a ready-made Lua package for your platform, you'll probably need the development package as well. Otherwise, just download Lua and add its source directory to your project.

    Cloud we replace the patch(patches/lua.patch) with this commit? lua/lua@9a3940

    Maybe. Or we can update the minSdk to 24.

  6. Bambooin commented on Apr 9, 2026

    @Bambooin
    CollaboratorAuthor

    Duplicated with #1975

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions