vm: drop paramiko, use opeensh and add retry #1156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
requested review from
achilleas-k,
bcl and
supakeen
and removed request for
a team
mvo5
force-pushed
the
drop-paramiko
branch
2 times, most recently
from
e65dc81 to
9bec074
Compare
This was referenced Nov 20, 2025
mvo5
force-pushed
the
drop-paramiko
branch
3 times, most recently
from
aa1b648 to
2b71666
Compare
supakeen
previously approved these changes
Nov 20, 2025
bcl
reviewed
Nov 20, 2025
bcl
reviewed
Nov 20, 2025
bcl
reviewed
Nov 20, 2025
mvo5
force-pushed
the
drop-paramiko
branch
3 times, most recently
from
4cbb6a8 to
f45f0dc
Compare
supakeen
previously approved these changes
Nov 20, 2025
And replace with ssh/scp binaries. This is probably more robust than paramiko and more "standard". As a side effect we do no longer request an explicit tty. We could force that with "-t" in ssh but we did that with paramiko and that caused issues that e.g. "systemctl" would detect a tty and go into pager mode. So lets start without and we can always add "-t" to our ssh invocation to force it.
Small helper to retry ssh to avoid flakyness when a VM closes the connection too early.
supakeen
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vm: drop paramiko
And replace with ssh/scp binaries. This is probably more
robust than paramiko and more "standard". As a side effect
we do no longer request an explicit tty. We could force
that with "-t" in ssh but we did that with paramiko and
that caused issues that e.g. "systemctl" would detect
a tty and go into pager mode. So lets start without and
we can always add "-t" to our ssh invocation to force
it.
vmtest: add new _ensure_ssh() that will retry 3x to login
Small helper to retry ssh to avoid flakyness when a VM closes the
connection too early.