bib: use images lib to generate the rpm ISO [HMS-9297] #1131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
changed the title
mvo5
force-pushed
the
bootc-anaconda-iso-2
branch
from
b18ab2e to
656d33a
Compare
mvo5
changed the title
mvo5
force-pushed
the
bootc-anaconda-iso-2
branch
from
656d33a to
efc99d8
Compare
…mvo5/images@bootc-anaconda-iso-2 && go mod tidy
mvo5
force-pushed
the
bootc-anaconda-iso-2
branch
from
efc99d8 to
c7dd947
Compare
Drop legacy_iso.go and use the images library to build the image.
mvo5
force-pushed
the
bootc-anaconda-iso-2
branch
from
c7dd947 to
7887324
Compare
This was referenced Nov 14, 2025
Merged
Collaborator
Author
|
I'm closing this in favor of osbuild/image-builder-cli#374 and #1157 - I think instead of this we can focus on making it a multicall binary directly. If it turns out to be too difficult/too much churn in a single go we can revisit/reopen this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[draft as this needs https://github.com/osbuild/images/pull/2007 and https://github.com/osbuild/images/pull/2010 first]
Drop legacy_iso.go and use the images library to build the
image.
We probably also want something like https://github.com/osbuild/images/pull/1804/files#diff-7a537ca8934a30b5cf043848aa0921b3f0fc61a2a0c117c83e83db94b4f5ea9f here