distro: add ISO support for bootc images (HMS-9297) #1804
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Honestly, it's easy to skip over but custom depsolvers per distro is a pretty huge thing! I love it. |
mvo5
force-pushed
the
distro-bootc-with-iso
branch
from
bbe53a9 to
14e9bf3
Compare
schutzbot
changed the title
The bootc based distros need a custom depsolver because they need to use the dnf from the container to ensure that all the plugins/custom config is used. So manifestgen now checks if the distro defines its own way to depsolve and if so uses that instead of using the default way. Note that this means that bootc ISOs (that require rpms) are incompatible with custom depsolve helpers.
mvo5
force-pushed
the
distro-bootc-with-iso
branch
from
5798b53 to
d141f65
Compare
Contributor
|
A previous version of this PR changed the images API or behaviour causing integration issues with osbuild-composer. |
mvo5
force-pushed
the
distro-bootc-with-iso
branch
from
166aa15 to
99ba8d6
Compare
|
This PR is stale because it had no activity for the past 30 days. Remove the "Stale" label or add a comment, otherwise this PR will be closed in 7 days. |
Member
|
This will need to implement osbuild/bootc-image-builder#1073 as well. |
Contributor
Author
|
Closing in favor of osbuild/bootc-image-builder#1131 which is much nicer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[draft as this needs some cleanups and tests first but the idea is there, we also need to port https://github.com/osbuild/bootc-image-builder/pull/1048 (if we decide to do it)]
This commit adds support to build ISO images for the bootc distro.
The core idea is that the
distro.Distroabstraction can have custom depsolvers. This makes sense anyway if we ever want to support non-rpm distros. For bootc we need it because we run the dnf from inside the container to be sure that we get all custom plugins/repo config etc.This is otherwise a (mostly) 1-1 copy of the code we have already in bib.
/jira-epic HMS-8839
JIRA: HMS-9297