Skip to content

auth-oauth2: log callback failures to system logs #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pmdrs wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

auth-oauth2: log callback failures to system logs #304

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion auth-oauth2/oauth2.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ function __construct($config, $provider=null) {
}

function callback($resp, $ref=null) {
//TODO: Log any errors to system logs
global $ost;
try {
if ($this->getState() == $resp['state']
&& ($token=$this->provider->getToken($resp['code']))
Expand All @@ -97,9 +97,26 @@ function callback($resp, $ref=null) {
// desired panel
if ($this->login($result, $this))
$this->onSignIn();
} elseif ($ost) {
$ost->logWarning(sprintf('%s: Sign In Failed',
$this->getServiceName()),
'The identity provider returned valid attributes, '
.'but no local account could be matched or '
.'auto-registered for them.', false);
}
} elseif ($ost) {
$ost->logWarning(sprintf('%s: OAuth2 Callback Failed',
$this->getServiceName()),
'The OAuth2 callback did not complete: the state '
.'parameter did not match, or the identity provider '
.'did not return a usable access token / owner '
.'attributes (e.g. invalid_client, invalid_grant, or '
.'an expired authorization code).', false);
}
} catch (Exception $ex) {
if ($ost)
$ost->logError(sprintf('%s: OAuth2 Authentication Error',
$this->getServiceName()), $ex->getMessage(), false);
return false;
}
}
Expand Down