Skip to content

feat: add docs for ory elements #2198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 19 commits into
base: master
Choose a base branch
from
Draft

Conversation

jonas-jonas
Copy link
Member

Related Issue or Design Document

Checklist

  • I have read the contributing guidelines and signed the CLA.
  • I have referenced an issue containing the design document if my change introduces a new feature.
  • I have read the security policy.
  • I confirm that this pull request does not address a security vulnerability.
    If this pull request addresses a security vulnerability,
    I confirm that I got approval (please contact [email protected]) from the maintainers to push the changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added the necessary documentation within the code base (if appropriate).

Further comments

Copy link
Member

@aeneasr aeneasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice changes!

Will the reference docs be auto-synched from the internal repo?

@@ -84,14 +84,56 @@ enterprise identity providers. It’s modular, supports your preferred database,
data and privacy. Built for flexibility and scale, Ory Polis handles as many tenants and identity providers as your business
demands. If you're delivering enterprise-grade SaaS and need SSO that just works, Ory Polis is the missing link.

## Ory Elements

![Ory Elements](https://raw.githubusercontent.com/ory/meta/master/static/logos/logo-elements.svg)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

broken image

## All of Ory Open Source

![Full Ory Ecosystem](./_static/projects/1.png)

```mdx-code-block
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this! In a follow up I think we could move this to the top.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot I put this in here. It's a ChatGPT'd version of the image above. But Mermaid is much easier to update. We just need to style it some more.

Comment on lines 58 to 60
Related docs:

- [account-experience](../account-experience/index.mdx)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea (ideally docusaurus would support this with metadata?) but since we don't do this anywhere else I'm not sure if we should keep this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaict docusaurus doesn't support it directly.

but they support "tags" and custom components.
So we can add a custom component that links to other related docs through the tags relatively easy.

the biggest hurdle would be to add tags to all documents - but we can probably use an LLM for this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was more of a to-do list for myself, and we need to rework that doc anyway. Would be good to establish this pattern, though. Maybe LLMs can.

your application. Here is an example of how to create a custom theme:

```css title="theme.css"
:root {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Missing variables
  • Maybe link to somewhere where the variables are explained?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I am still working through getting a description for each variable. And cleaning up unused ones.

@@ -0,0 +1,179 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!


## Project configuration

The `project` configuration is used to configure the overall behavior of the Ory Elements UI components. It includes settings such
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will soon / now be loaded by the API right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, that's the idea. Though I am not actually sure how to implement this, right now. In Next.js you'd want to fetch it on the server side and pass to Ory Elements, but in plain react it would need to be fetched by the client. Going to have to think about it a bit more, I fear.

are available at the correct paths, such as `/self-service/login`, `/self-service/registration`, etc. on the same origin as your
application. This is the default behavior when using Ory Elements in a Next.js application with the Ory middleware.

:::caution
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should cover this in a "From dev to production" and / or "Hosting on Vercel" guide instead. There we can explain the nextjs middleware and how it works with vercel preview deployments and then how to configure it when going to prod.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe. But we need to explain this in a little detail here, too. I'd just look at the configuration page, and expect it to cover all facets of the configuration. I'll think about the going to prod guide a bit more.

@jonas-jonas
Copy link
Member Author

Will the reference docs be auto-synched from the internal repo?

They definitely can be, and should be. I think that needs to happen on release. And, very important: through a PR in the docs repo. Otherwise, we won't notice broken links.

Comment on lines 58 to 60
Related docs:

- [account-experience](../account-experience/index.mdx)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaict docusaurus doesn't support it directly.

but they support "tags" and custom components.
So we can add a custom component that links to other related docs through the tags relatively easy.

the biggest hurdle would be to add tags to all documents - but we can probably use an LLM for this?

Co-authored-by: Vincent <[email protected]>
Co-authored-by: hackerman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants