Add support for private registry images in presets #1192
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds first-class support for pulling container images from private registries
Motivation
Gnomock is often used in CI and enterprise environments where base images are mirrored or hosted in private registries for security and reliability. Today, the Postgres preset hardcodes the Docker Hub library image, which makes using private registries cumbersome or impossible without custom forks.
Chages is fully backward-compatible:
ImageName
is not set, the preset behaves exactly as before.Usage
ImageName
to your registry path and keepVersion
:WithImage("registry.example.com/team/postgres").WithVersion("16.2")
Request for early feedback
If maintainers are comfortable with this structure, I will implement the same pattern for other presets (e.g., MySQL, MongoDB, Redis, etc.) in this PR
Open questions