Skip to content

CICD-5561: bump handlebars 4.7.8 -> 4.7.9 - #16

Merged
ronitaktook-orca merged 1 commit into
masterfrom
CICD-5561-bump-handlebars
Sep 2, 2026
Merged

ronitaktook-orca merged 1 commit into
masterfrom
CICD-5561-bump-handlebars

Conversation

@ronitaktook-orca

@ronitaktook-orca ronitaktook-orca commented Sep 2, 2026 •

Copy link
Copy Markdown
Collaborator

What

Bumps handlebars 4.7.8 → 4.7.9 in package-lock.json.

Fixes CICD-5561 (Orca alert orca-158035636).

Why this is a lockfile-only change

package.json already declares "handlebars": "^4.7.8" as a direct dependency, and that caret range already admits 4.7.9 — the lockfile just hadn't been regenerated. So there is no manifest edit and no range tightening (^4.7.8 is left as-is deliberately; narrowing it adds churn without adding protection).

4.7.9 is the current latest on npm and the only published version above 4.7.8 — a single patch step within the same minor, no major crossing.

Refreshed with npm update handlebars --lockfile-version=2 (rather than npm install handlebars@4.7.9) so that:

  • package.json is not rewritten, and
  • the lockfile stays at lockfileVersion: 2 instead of being migrated to v3, which would have turned a 7-line diff into thousands.

No dist/ rebuild is needed — this is a Docker-based action and dist/ is built inside the container at runtime (npm run build --if-present in entrypoint.sh); there is no committed bundle to regenerate.

Verification

Run locally on this branch:

  • npm ci — succeeds. This is the install path the Dockerfile uses, so it confirms the lockfile is in sync with package.json. (unit-tests.yml uses npm install, which would not catch a desync.)
  • npm ls handlebars → handlebars@4.7.9
  • npm run lint — clean
  • npm test — 14/14 pass. src/summary.js is the only handlebars consumer.
  • npm audit — handlebars no longer appears.

On this PR, test-secrets-action.yaml and test-secrets-action-sarif.yaml both build the action image via uses: ./ and run a real scan, exercising src/summary.js end to end.

Remaining npm audit findings (js-yaml, minimatch, picomatch) are dev-dependency-only and out of scope for this ticket.

Note

Because the README pins consumers to @v1, the v1 tag needs to be re-pointed after release for this fix to actually reach anyone.

Patches the vulnerabilities reported for handlebars-4.7.8 (alert
orca-158035636). package.json already declares "^4.7.8", which admits
4.7.9, so this is a lockfile refresh only - no manifest change and no
range tightening.

Refreshed with 'npm update handlebars --lockfile-version=2' to keep the
lockfile at version 2 and avoid unrelated churn.

@orca-security-eu orca-security-eu Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Orca Security Scan Summary

Status Check Issues by priority
Passed Passed Secrets high 0   medium 0   low 0   info 0 View in Orca
Passed Passed Vulnerabilities high 0   medium 0   low 0   info 0 View in Orca

@sonarqubecloud

sonarqubecloud Bot commented Sep 2, 2026

Copy link
Copy Markdown

@ronitaktook-orca
ronitaktook-orca merged commit 11731c5 into master Sep 2, 2026
12 checks passed
@ronitaktook-orca
ronitaktook-orca deleted the CICD-5561-bump-handlebars branch September 2, 2026 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants