update load price chart #1182
Open
update load price chart #1182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trungbach
previously approved these changes
Apr 21, 2025
quangdz1704
previously approved these changes
Apr 21, 2025
Deploying beta-oraidex with
|
| Latest commit: |
57252ae
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://840cc62f.beta-oraidex.pages.dev |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -119,9 +119,9 @@ | |||
| <div className={cx('left')}> | |||
| <div className={cx('icon')}> | |||
| {(token.icon && isConfirmToken === 'init') || isConfirmToken === 'confirmed' ? ( | |||
| <img className={cx('logo')} src={token.icon} alt="icon" width={30} height={30} /> | |||
| <img className={cx('logo')} style={{ borderRadius: '100%', backgroundColor: token?.coinGeckoId === 'usdai' ? 'white' : 'transparent' }} src={token.icon} alt="icon" width={30} height={30} /> | |||
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI 4 months ago
To fix the issue, we need to ensure that the token.icon value is sanitized or validated before being used as the src attribute of an <img> tag. A common approach is to validate that the URL is a safe and valid image URL. This can be achieved by:
- Using a utility function to validate the URL format and ensure it points to an image.
- Replacing invalid or unsafe URLs with a default placeholder image.
The changes will be made in InputSwap.tsx to validate the token.icon value before rendering it. Additionally, we will introduce a utility function for URL validation.
Suggested changeset
1
src/pages/UniversalSwap/Swap/components/InputSwap/InputSwap.tsx
| @@ -16,4 +16,13 @@ | ||
|
|
||
| const cx = cn.bind(styles); | ||
| const isValidImageUrl = (url: string | undefined): boolean => { | ||
| if (!url) return false; | ||
| try { | ||
| const parsedUrl = new URL(url); | ||
| return ['http:', 'https:'].includes(parsedUrl.protocol) && /\.(jpeg|jpg|gif|png|svg|webp)$/.test(parsedUrl.pathname); | ||
| } catch { | ||
| return false; | ||
| } | ||
| }; | ||
|
|
||
| const cx = cn.bind(styles); | ||
| interface InputSwapProps { | ||
| @@ -120,3 +129,3 @@ | ||
| <div className={cx('icon')}> | ||
| {(token.icon && isConfirmToken === 'init') || isConfirmToken === 'confirmed' ? ( | ||
| {(isValidImageUrl(token.icon) && isConfirmToken === 'init') || isConfirmToken === 'confirmed' ? ( | ||
| <img className={cx('logo')} style={{ borderRadius: '100%', backgroundColor: token?.coinGeckoId === 'usdai' ? 'white' : 'transparent' }} src={token.icon} alt="icon" width={30} height={30} /> |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.