Skip to content

Align SLF4J NOP provider with the 2.x API - #5023

Open
eyesofish wants to merge 1 commit into
oracle:masterfrom
eyesofish:fix-5009-slf4j-nop
Open

eyesofish wants to merge 1 commit into
oracle:masterfrom
eyesofish:fix-5009-slf4j-nop

Conversation

@eyesofish

Copy link
Copy Markdown

Summary

  • manage slf4j-api and slf4j-nop at 2.0.18
  • let the suggester use the managed NOP provider so the webapp no longer packages a 1.7 binding with a 2.x API

Testing

  • ./mvnw -q -pl suggester test -Dmaven.gitcommitid.skip=true
  • ./mvnw -q -pl opengrok-web -am package -DskipTests -Dmaven.gitcommitid.skip=true
  • verified the WAR contains slf4j-api-2.0.18.jar and slf4j-nop-2.0.18.jar
  • verified LoggerFactory loads org.slf4j.helpers.NOPLoggerFactory without startup warnings

Fixes #5009

@oracle-contributor-agreement

Copy link
Copy Markdown

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Aug 27, 2026
Manage the SLF4J API and NOP provider at 2.0.18 so every module resolves a compatible provider and the webapp starts without ignored-binding warnings.

Fixes oracle#5009

Signed-off-by: eyesofish <110754016+eyesofish@users.noreply.github.com>
@vladak

vladak commented Sep 14, 2026

Copy link
Copy Markdown
Member

Please rebase. Any news w.r.t. OCA ?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Required At least one contributor does not have an approved Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

slf4j-nop 1.7.30 no longer silences SLF4J: the war ships slf4j-api 2.0.13, which ignores 1.7 bindings

2 participants