fix(pypi): update get_maintainers_of_package to avoid request blocking #1097
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Signed-off-by: Amine <[email protected]>
AmineRaouane
force-pushed
the
improve_pypi_registry
branch
from
7401155 to
7e41b96
Compare
art1f1c3R
reviewed
Jun 4, 2025
behnazh-w
reviewed
Jun 5, 2025
| @@ -244,11 +244,10 @@ def get_package_page(self, package_name: str) -> str | None: | |||
| str | None | |||
| The package main page. | |||
| """ | |||
| url = os.path.join(self.registry_url, "project", package_name) | |||
| url = f"https://pypi.org/project/{package_name}/" | |||
There was a problem hiding this comment.
@AmineRaouane Please add a comment above this line to emphasize why / at the end is important.
| response = send_get_http_raw(url) | ||
| if response: | ||
| html_snippets = response.content.decode("utf-8") | ||
| return html_snippets | ||
| return response.text |
Signed-off-by: Amine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the functionality of the pypi_registry.py by enhancing the reliability of requests made to the PyPI registry.
Description of changes
Related issues
Checklist
verifiedlabel should appear next to all of your commits on GitHub.