[GR-75232] Remove use-graalvm from standalone pointsto tests#13443
Closed
graalvmbot wants to merge 1 commit intomasterfrom
Closed
[GR-75232] Remove use-graalvm from standalone pointsto tests#13443graalvmbot wants to merge 1 commit intomasterfrom
graalvmbot wants to merge 1 commit intomasterfrom
Conversation
oracle-contributor-agreement
Bot
added
the
OCA Verified
Run the Espresso-backed standalone points-to unit tests on the regular mx-launched VM and pass the Java home of the built GraalJDK explicitly to VMAccess. This keeps the test command aligned with normal mx build outputs instead of relying on --use-graalvm. Add the Espresso VMAccess, language resources, and Truffle NFI dependencies needed by the standalone unit-test configuration so the Espresso path can be assembled from a clean build. Keep native access enabled for org.graalvm.truffle to avoid restricted native-access warnings around NFI loading. Teach PointsToAnalyzer to prefer the explicit VMAccess Java home property, and have Espresso VMAccess fail early when the temporary Polyglot engine cannot see the Java language. That produces a clear setup error before java.* options or guest VM options are processed.
graalvmbot
force-pushed
the
d-kozak/GR-75232/standalone-remove-use-graalvm
branch
from
598c208 to
ea6b844
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove
--use-graalvmfromstandalone-pointsto-unittestand make the Espresso-backed standalone analysis test setup explicit under the normal mx launcher.Changes
standalone-pointsto-unittest espressowithout switching the test VM to a GraalVM launch mode.com.oracle.graal.pointsto.standalone.vmaccess.java.home.PointsToAnalyzerprefer that explicit VMAccess Java home over the processjava.home.org.graalvm.truffleso Espresso NFI loading does not rely on restricted native access warnings.EspressoExternalVMAccessBuilder.build()when the temporary Polyglot engine cannot see thejavalanguage, before configuringjava.*options or processing VM options.Validation
ESPRESSO_VMACCESSwhile removing the Espresso language/runtime deps;standalone-pointsto-unittest espressonow fails early with a descriptiveIllegalStateExceptionthat the Polyglot engine does not expose thejavalanguage.mx -p graal/substratevm --dy /espresso-compiler-stubcontext, including rebuilds of the standalone test closure, GraalJDK, Truffle NFI libffi, and Espresso deps.mx -p graal/espresso-compiler-stub --strict-compliance eclipseformat --primarymx -p graal/espresso-compiler-stub --strict-compliance checkstyle --primarymx -p graal/espresso-compiler-stub --strict-compliance build -f --warning-as-error --jdt builtin --projects com.oracle.truffle.espresso.vmaccessmx -p graal/espresso-compiler-stub --strict-compliance build -f --warning-as-error --force-javac --projects com.oracle.truffle.espresso.vmaccessmx -p graal/substratevm --dy /espresso-compiler-stub --strict-compliance build -f --warning-as-error --jdt builtin --projects com.oracle.graal.pointsto.standalonemx -p graal/substratevm --dy /espresso-compiler-stub --strict-compliance build -f --warning-as-error --force-javac --projects com.oracle.graal.pointsto.standalonemx -p graal/substratevm --dy /espresso-compiler-stub --strict-compliance build -f --warning-as-error --force-javac --dependencies=ESPRESSO_VMACCESSmx -p graal/substratevm --dy /espresso-compiler-stub standalone-pointsto-unittest espressomx -p graal/substratevm --dy /espresso-compiler-stub standalone-pointsto-unittest host