Fix checkByteArrayIllegal loop condition in ObjectState#13231
Open
cuiweixie wants to merge 1 commit intooracle:masterfrom
Open
Fix checkByteArrayIllegal loop condition in ObjectState#13231cuiweixie wants to merge 1 commit intooracle:masterfrom
cuiweixie wants to merge 1 commit intooracle:masterfrom
Conversation
The loop advances j to skip trailing illegal constants but compared values[i] instead of values[j], so the termination condition was wrong when multiple illegal slots follow the primitive.
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
oracle-contributor-agreement
bot
added
the
OCA Required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the loop in
ObjectState.checkByteArrayIllegalthat skips trailing illegal constants after a primitive in a byte array. The loop variable isj, but the condition incorrectly usedvalues[i], so the loop did not advance correctly when multiple illegal slots follow the primitive.Testing
totalBytes/ stamps caveat).