Chrome Inspector Tool: Fix info messages written to error stream#13223
Chrome Inspector Tool: Fix info messages written to error stream#13223graalvmbot merged 4 commits intooracle:masterfrom
Conversation
|
Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application. When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated. If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public. |
|
Thank you for signing the OCA. |
|
Thanks for the fix, and thank you for contributing this. I took a close look at the change and ran the relevant chrome inspector tests locally with What I found:
The failures line up with the PR change: So overall this looks like the right fix to me, but I do think the test update should be included before merging. Thanks again for the contribution. 🤖 |
fniephaus
left a comment
There was a problem hiding this comment.
Please update InspectorAddressTest.
|
@fniephaus Thanks for your review! |
We don't run the tests on GitHub CI, too bad you cannot run them on Fedora. I will share any problems caught by our internal CI. |
...meinspector.test/src/com/oracle/truffle/tools/chromeinspector/test/InspectorAddressTest.java
Outdated
Show resolved
Hide resolved
|
|
|
I built me a Docker container based on Ubuntu to run mx and it works fine. |
Fixes #13222.