Fix groovy substitutions for Groovy 5+#13097
Conversation
oracle-contributor-agreement
bot
added
the
OCA Verified
|
@vjovanov Could you please help get a fix like this one integrated? Thank you! |
|
Yes, ideally we want to move features like this into the language or library. However, this feature seems to be valid only for earlier versions of Groovy so we don't need to move it. This should be also backported to 25 until we get the feature into Groovy and for Groovy previous versions. |
|
I can cover the GraalVM 25 community backport once this fix is integrated. |
|
I mirrored the PR and should proceed with it once the gates are all green |
Thanks! |
|
|
The method to be substituted moved from the v7 to the v8 package from Groovy 4 to Groovy 5 Closes: oracle#13096
jerboaa
force-pushed
the
polyglot-fix-groovy-5
branch
from
7e522b5 to
7552858
Compare
|
The updated patch checks both |
|
GHA failure seems unrelated. I see the same math stubs failure in #13207 |
|
@vjovanov @oubidar-Abderrahim Could we please move forward with this? It's causing test noise in our CI for testing quarkus on graal/master (which we run daily). Thank you! |
|
@jerboaa sorry for the delay. We had a miscommunication about who is managing this PR. We have replaced the reflection acces with |
|
OK, thanks! |
linghengqian
left a comment
linghengqian
left a comment
There was a problem hiding this comment.
It appears that 7e522b5 is now on the master branch?
6 participants
The feature originally expects the
org.codehaus.groovy.vmplugin.v7.IndyInterfaceclass to be present for it to be "in config". This is no longer sufficient since Groovy 5 has the substituted method moved to thev8package. See:https://docs.groovy-lang.org/docs/groovy-5.0.0/html/api/org/codehaus/groovy/vmplugin/v8/IndyInterface.html
Instead, check that the method is present as well for the feature to be in config. Use the version specific substitution depending on the Groovy version.
Testing:
Closes: #13096