Skip to content

Conversation

@izeye
Copy link
Contributor

@izeye izeye commented May 11, 2025

This PR removes an extra dot in @Option deprecationMessage attribute in the ConfigurationFiles.Options.DynamicProxyConfigurationResources as the ending dot doesn't seem to be expected as follows:

String deprecationMessage = descriptor.getDeprecationMessage();
if (deprecationMessage != null && !deprecationMessage.isEmpty()) {
message += ": " + deprecationMessage;
}
message += ". Please refer to the GraalVM release notes.";

See spring-projects/spring-framework#34855 (comment)

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label May 11, 2025
@izeye izeye changed the title Remove extra dot in ConfigurationFiles.Options.DynamicProxyConfigurationResources Remove extra dot in Option.deprecationMessage in ConfigurationFiles.Options.DynamicProxyConfigurationResources May 11, 2025
@selhagani selhagani self-assigned this Aug 27, 2025
@selhagani selhagani requested a review from olyagpl August 27, 2025 18:05
@selhagani
Copy link

Hi @izeye,

Thank you for your kind contribution, we appreciate it!

@olyagpl
Copy link
Member

olyagpl commented Aug 29, 2025

We'll follow up on this as part of some other PR. The dot fix is really minor to run all testing gates for. Thank you for understanding!

@olyagpl olyagpl closed this Aug 29, 2025
@izeye izeye deleted the dot branch August 29, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants