Skip to content

fix: Prevent data race by removing global variable #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Prevent data race by removing global variable #148

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions client/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,6 @@ func (rm *ResultMetadata) ValidateResultMetadata() error {
return nil
}

var UserAgentHeader string

const Version = "2.0.0"

func setConfiguration(opsGenieClient *OpsGenieClient, cfg *Config) {
Expand Down Expand Up @@ -237,7 +235,6 @@ func setRetryPolicy(opsGenieClient *OpsGenieClient, cfg *Config) {
}

func NewOpsGenieClient(cfg *Config) (*OpsGenieClient, error) {
UserAgentHeader = fmt.Sprintf("opsgenie-go-sdk-%s %s (%s/%s)", Version, runtime.Version(), runtime.GOOS, runtime.GOARCH)
opsGenieClient := &OpsGenieClient{
Config: cfg,
RetryableClient: retryablehttp.NewClient(),
Expand Down Expand Up @@ -365,12 +362,16 @@ func (cli *OpsGenieClient) buildHttpRequest(apiRequest ApiRequest) (*request, er
}
req.Header.Add("Accept", "application/json")
req.Header.Add("Authorization", "GenieKey "+cli.Config.ApiKey)
req.Header.Add("User-Agent", UserAgentHeader)
req.Header.Add("User-Agent", buildUserAgentHeader())

return &request{req}, err

}

func buildUserAgentHeader() string {
return fmt.Sprintf("opsgenie-go-sdk-%s %s (%s/%s)", Version, runtime.Version(), runtime.GOOS, runtime.GOARCH)
}

func buildRequestUrl(cli *OpsGenieClient, apiRequest ApiRequest, queryParams url.Values) string {
requestUrl := url.URL{
Scheme: string(Https),
Expand Down