Skip to content

Conversation

awgreene
Copy link
Member

Update the subscription.md document to explain why a Subscription cannot adopt existing ClusterServiceVersions that are not associated with it.

Signed-off-by: Alexander Greene [email protected]

@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2022

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: awgreene
Once this PR has been reviewed and has the lgtm label, please assign kevinrizza for approval by writing /assign @kevinrizza in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@timflannagan timflannagan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick drive by review.

@awgreene awgreene force-pushed the resolution-constraint branch 2 times, most recently from 9fde96d to b1c08d9 Compare September 13, 2022 17:05
@timflannagan
Copy link
Member

Just one more comment but this lgtm.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2022
- The `Subscription` requires an `CSV` that fulfills it.
- The existing `CSV` must appear in the solution set (remember, it cannot fulfill the requirements of `Subscriptions` it is not associated with).

This ultimately returns a failure message similar to:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect readers to see this and assume that any similar-looking error prefix will have the same underlying cause. This document's purpose isn't to explain the way constraints are modeled inside the catalog operator, but it would benefit from a little exposition about the constraints within the message.

@awgreene awgreene force-pushed the resolution-constraint branch from b1c08d9 to 37eee1e Compare September 13, 2022 20:35
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 13, 2022
@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2022

New changes are detected. LGTM label has been removed.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 23, 2022
@@ -29,6 +29,35 @@ If the `Status` block does not provide enough information, check the [Catalog op

`Subscriptions` cannot install operators provided by `CatalogSources` that are not in the same namespace unless the `CatalogSource` is created in the `olm` namespace.

### A subscription fails because I deleted a similar subscription and left the CSV it installed

By creating a `Subscription`, the user is "subscribing" to updates from a particular package and channel within a `CatalogSource`. When a `ClusterServiceVersion (CSV)` is created to fulfill the `Subscription`, the `Subscription` is updated so it is "associated" with that `CSV`. "Associated" `CSVs` do not need to appear in the solution set allowing the `Subscription's` requirements to be met by `CSVs` in the channel that are valid upgrades from the existing `CSV`.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: "Subscription's" -> "Subscription's"

@grokspawn grokspawn added the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Sep 11, 2024
@perdasilva perdasilva force-pushed the resolution-constraint branch from 37eee1e to 32fbaa3 Compare November 25, 2024 09:53
Update the subscription.md document to explain why a Subscription
cannot adopt existing ClusterServiceVersions that are not associated
with it.

Signed-off-by: Alexander Greene <[email protected]>
Signed-off-by: Per Goncalves da Silva <[email protected]>
@perdasilva perdasilva force-pushed the resolution-constraint branch from 32fbaa3 to 326e816 Compare November 25, 2024 10:06
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 25, 2024
@perdasilva perdasilva enabled auto-merge (squash) November 25, 2024 10:06
@perdasilva perdasilva merged commit 5b2f8e4 into operator-framework:master Nov 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants