Fix the computation of the layover/shadow mask over the antimeridian for DEM in polar stereo #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oberonia78
approved these changes
May 22, 2025
Contributor
oberonia78
left a comment
oberonia78
left a comment
There was a problem hiding this comment.
LGTM. Thanks @gshiroma
Collaborator
Author
|
Thank you, @oberonia78 ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #94.
This PR fixes the creation of the layover/shadow mask for S1 bursts crossing the antimeridian when the DEM is provided in polar stereo projection. The ISCE3 Topo module interpolates the DEM using the input
epsg_code, which defaults to4326. Topo only tests for the antimeridian crossing when the DEM interpolator is set to4326, rather than evaluating theoutput_epsg. This causes an error when computing the layover/shadow mask for S1 bursts crossing the antimeridian if the DEM is provided in polar stereographic coordinates andoutput_epsgis set to4326, or not set, which defaulting to4326.