Skip to content

Conversation

@oberonia78
Copy link
Contributor

@oberonia78 oberonia78 commented May 2, 2025

This PR upgrades our core SAR dependencies and adapts the RTC-S1 workflow so we can ingest and process Sentinel-1C data.

Package Old version New version Rationale
s1reader 0.24.0 0.25.0 Updates s1reader. However, this update does not impact on the RTC-S1.

@oberonia78 oberonia78 requested a review from gshiroma May 2, 2025 01:00
Copy link
Collaborator

@gshiroma gshiroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you, @oberonia78 !

@gshiroma
Copy link
Collaborator

gshiroma commented May 2, 2025

Just realized that CI failed =/

@oberonia78
Copy link
Contributor Author

@gshiroma I think the failure is like

          raise AttributeError(
                f"`np.{attr}` was removed in the NumPy 2.0 release. "
                f"{__expired_attributes__[attr]}",
                name=None
            )
E           AttributeError: `np.string_` was removed in the NumPy 2.0 release. Use `np.bytes_` instead.

So, I think we can resolve the issue after merging your PR #91 . I'll further investigate the other issues.

@gshiroma
Copy link
Collaborator

gshiroma commented May 2, 2025

@gshiroma I think the failure is like

          raise AttributeError(
                f"`np.{attr}` was removed in the NumPy 2.0 release. "
                f"{__expired_attributes__[attr]}",
                name=None
            )
E           AttributeError: `np.string_` was removed in the NumPy 2.0 release. Use `np.bytes_` instead.

So, I think we can resolve the issue after merging your PR #91 . I'll further investigate the other issues.

That makes sense. Thank you, @oberonia78 .

@gshiroma gshiroma mentioned this pull request May 20, 2025
@oberonia78 oberonia78 merged commit 9ecd918 into opera-adt:main May 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants