Skip to content

Conversation

@jcchavezs
Copy link
Contributor

No description provided.

jcchavezs and others added 3 commits June 30, 2021 11:18
* add aggregation class and interface

* update doc block

* add cache functionality #22

* add Bulk class

* add memcached reporter

* finalize memcache reporter #22

* finalize memcache reporter #22

* update

* add teset case

* add test cases

* add test cases

* add ext-memcached to requirements

* remove ext-memcached

* update options to array

* support single process reporting

* thow exception if memcahced ext not installed

* small fix

* rename cas method and report on failure

* Support single process reporting and update test cases

* add rest of test cases

* small change

* chore: fix lint

* fix phpstan errors

Co-authored-by: José Carlos Chávez <[email protected]>
@coveralls
Copy link

coveralls commented Sep 12, 2021

Pull Request Test Coverage Report for Build #489

  • 89 of 115 (77.39%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.1%) to 85.585%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Zipkin/Reporters/Memcached.php 89 96 92.71%
src/Zipkin/Reporters/Aggregation/MemcachedClient.php 0 19 0.0%
Totals Coverage Status
Change from base Build #472: -1.1%
Covered Lines: 849
Relevant Lines: 992

💛 - Coveralls

@jcchavezs jcchavezs added this to the 3.1 milestone Sep 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants