Skip to content

Fix several raidz_test issues #17977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix several raidz_test issues #17977

wants to merge 4 commits into from

Conversation

@amotin
Copy link
Member

@amotin amotin commented Nov 24, 2025 •
edited
Loading

Trying to investigate CI raidz_001_neg failures on FreeBSD 16 I ended up with few patches.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

@amotin
ZFS: Enable more logs for raidz_001_neg
2cba99c 
The output is not so big here, so lets collect something useful.

Signed-off-by: Alexander Motin <[email protected]>
@amotin
raidz_test: Set io_offset reasonably
91dd365 
 - io_offset of 1 makes no sense.  Set default to 0.
 - Initialize io_offset in all cases.

Signed-off-by: Alexander Motin <[email protected]>
@amotin
raidz_test: Fix ZIO ABDs initialization
a902ee7 
 - When filling ABDs of several segments, consider offset.
 - "Corrupt" ABDs with actually different data to fail something.

Signed-off-by: Alexander Motin <[email protected]>
@amotin
raidz_test: Restore rand_data protection
0b8532a 
It feels dirty to modify protection of a memory allocated via libc,
but at least we should try to restore it before freeing.

Signed-off-by: Alexander Motin <[email protected]>
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Status: Code Review Needed Ready for review and testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@amotin