Skip to content

zed: prettify slack notification message #17610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

PandaScience
Copy link
Contributor

Motivation and Context

Currently, when sending ZED notifications to slack, the message is a bit hard to read because it is formatted as plain text:

screenshot_2025-08-10-161817

With this change, the body of the message is put in a monospaced code block which is far more convenient to read already because columns are properly aligned now:

screenshot_2025-08-10-161837

How Has This Been Tested?

Well, there is not that much to test. I've edited the respective file on my local zfs installation and been using it with this config for some time now. The slack api is well documented and code block formatting is a standard thing in webhook payloads. You can verify the result in the screenshots above.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Quality assurance (non-breaking change which makes the code more robust against bugs)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Library ABI change (libzfs, libzfs_core, libnvpair, libuutil and libzfsbootenv)
  • Documentation (a change to man pages or other documentation)

Checklist:

This converts the body of a ZED slack notification from
plain text to code block style to help with readability.

Signed-off-by: René Wirnata <[email protected]>
@PandaScience PandaScience force-pushed the prettify-zed-slack-notification branch from c5b4d8e to 4d6c866 Compare August 10, 2025 14:37
@amotin amotin added the Status: Code Review Needed Ready for review and testing label Aug 11, 2025
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Aug 11, 2025
@behlendorf behlendorf merged commit 1d0b94c into openzfs:master Aug 11, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants