cloudflare-worker: stop reporting things that are not true

[BKPepe]

Six findings from an independent audit, each a place where the bot told a contributor something that was not so.

A style rule OpenWrt does not have. The indentation check demanded two spaces on $(call Package/foo/Default), the line a package inherits shared metadata with. The tree does not agree on that style — 769 of those lines use two spaces, 601 sit at column 0, 148 start with a tab, and column 0 is the majority in the main repository. Neither does make: the block goes through $(eval), and three variants of the real gdb package differing only in that byte produce byte-identical metadata. That line is no longer judged. Ordinary metadata lines keep the two-space rule, which the tree does agree on, 13 219 against 1 603.

A green check over a file nobody read. When the check could not read a patch file at the head commit — a batched lookup answering 503, a ref gone after a force-push — the failure was swallowed and the file reported as a success. It is now counted and turns the conclusion neutral, the same state the run already uses for work the request budget cut short.

Labels that outlived what they described. add package, drop package and release/<version> were never taken off again, so a branch that dropped its package or was retargeted kept a label saying otherwise. All three are now withdrawn on the same terms they are applied. Labels from labeler.yml are left alone, the way GitHub's own labeler leaves them. A removal names the label the way the repository spells it — the packages feed calls it Add package.

One patch, two readings. The release audit and the hash audit each walked the commit patch themselves, and the walks had drifted; on 600 real commits one dropped content the other kept in 413 file/kind pairs. They now share one parser, which also stops at the mail signature GitHub appends to every commit patch. Read as diff content that signature is a deleted line, so a comment-only edit stopped counting as cosmetic and was told to bump PKG_RELEASE. All 120 sampled patches carried it.

A package that was never audited. package/utils/ucode is the ucode interpreter, but ucode also names a LuCI payload directory, so the walk to the package root skipped it, went up to the category and resolved to nothing. Every pull request touching it went unaudited without saying so. A directory directly under a category is now the package, not payload.

Conffiles rules the build system does not share. Make expansions were read as literal paths and all reported broken, though OpenWrt writes them throughout. Directories were required to end in a slash, which neither scripts/ipkg-build nor package-pack.mk can distinguish. Replaying the 408 Makefiles in the tree that define a conffiles block: 13 flagged before, 2 after, both genuinely indented.

Deploying now waits for the tests, which used to race it: both workflows triggered on the same push to main.

574 tests pass. Each fix has a test that fails when the fix is reverted.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.