Refactor #123
Open
Refactor #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
systemcrash
force-pushed
the
refactor
branch
from
2981593 to
0a6f12a
Compare
Contributor
Author
|
Ready for reviewing pleasure @Alphix |
systemcrash
force-pushed
the
refactor
branch
from
0a6f12a to
308c66f
Compare
Alphix
reviewed
Nov 19, 2025
Contributor
|
Other than that, LGTM |
improve readability Signed-off-by: Paul Donald <[email protected]>
for ia and pd entries Signed-off-by: Paul Donald <[email protected]>
re-using the priority field is very confusing, for the sake of saving a byte. Signed-off-by: Paul Donald <[email protected]>
improve readability Signed-off-by: Paul Donald <[email protected]>
improve readability Signed-off-by: Paul Donald <[email protected]>
improve readability Signed-off-by: Paul Donald <[email protected]>
improve readability Signed-off-by: Paul Donald <[email protected]>
systemcrash
force-pushed
the
refactor
branch
from
308c66f to
80f7be8
Compare
Contributor
Author
|
ping @Noltari - ready here I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will require a rebase for a one line change when the 'restart' PR goes in (struct will take advantage of byte padding from the compiler).
Purely a refactor - with the exception of adding
exclusion_lengthbecause stuffing one value into another property was confusing.