Skip to content

luci-app-frps: avoid saving the same form twice #9012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WROIATE wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

luci-app-frps: avoid saving the same form twice #9012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion applications/luci-app-frps/htdocs/luci-static/resources/view/frps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -964,7 +964,7 @@ return view.extend({
});
});

return E('div', { class: 'cbi-map' },
return E('div', {},

@openwrt-ai openwrt-ai Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: the sibling client app has the identical nested-cbi-map status wrapper at frpc.js:1415 and is left unchanged here, so frpc still double-saves. Is leaving it out intentional, or should the same one-line change land there too?

Generated by Claude Code

@WROIATE WROIATE Sep 7, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the solution should be the same.

E('fieldset', { class: 'cbi-section' }, [
E('p', { id: 'service_status' }, _('Collecting data ...'))
])
Expand Down