don't let a negative score be reported #1299
Merged
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Answers for this context are finite sets, like {1,2,3}. The scoring that happens in for answers attempts to give partial credit for answers like {1}, {1,2}, {1,2,4}, {1,2,3,4} etc. The idea is to use 3 as the denominator (in this case where the correct answer has three numbers) and then for the numerator:
But that can lead to a negative total. It doesn't get recorded int he database as a negative score (I think) but it does lead to students seeing things like "-100% correct" in the feedback.
So the change here ensures that if a negative total has been reached, that will be replaced with 0.