Fix several issues with the contextInteger.pl macro.
#1297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alex-Jordan
reviewed
Jul 23, 2025
Alex-Jordan
reviewed
Jul 23, 2025
drgrice1
force-pushed
the
context-integer-fixes
branch
from
e98ba98 to
815b571
Compare
Several times in the file the variable `$self` is used where it is not defined. So if the `$self->Error` method is actually called it results in the error "can't call Error on an undefined value". Also the wrong counts are used in the `randomPrime` method resulting in unexpected behavior. Finally, if the `$end` parameter to the `_getPrimesInRange` is prime, then include it in the returned primes in the range. Thus, the `randomPrime` method will potentially be the `$end` parameter. I.e., `randomPrime(1, 11)` could return 11. This is to address the things discussed in openwebwork#1296.
drgrice1
force-pushed
the
context-integer-fixes
branch
from
815b571 to
5e6734f
Compare
Alex-Jordan
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several times in the file the variable
$selfis used where it is not defined. So if the$self->Errormethod is actually called it results in the error "can't call Error on an undefined value".Also the wrong counts are used in the
randomPrimemethod resulting in unexpected behavior.Finally, if the
$endparameter to the_getPrimesInRangeis prime, then include it in the returned primes in the range. Thus, therandomPrimemethod will potentially be the$endparameter. I.e.,randomPrime(1, 11)could return 11.This is to address the things discussed in #1296.