Attach an agencyName to each monitored trip alert #1450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {alerts.map((alert) => ( | ||
| <AlertsBody | ||
| agencyName={alert.agencyName} | ||
| alerts={[alert]} |
There was a problem hiding this comment.
Are there any side effects caused by going from one AlertsBody to multiple for each alert?
There was a problem hiding this comment.
Maybe slight padding/offset differences from sequencing multiple AlertsBody instead of one. AlertsBody itself does not perform any side effects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requires ibi-group/otp-middleware#334.
This PR tweaks the alerts display for a monitored trip, so that the applicable agency name is shown in the alerts link, similar to what is currently happening with the alerts in the itinerary results.
PR Checklist