Select scooter mode when starting trip from scooter in nearby view #1449
Conversation
| @@ -319,6 +325,23 @@ class DefaultMap extends Component { | |||
| const baseLayerUrls = baseLayersWithNames?.map((bl) => bl.url) | |||
| const baseLayerNames = baseLayersWithNames?.map((bl) => bl.name) | |||
|
|
|||
| const overlayTypes = overlays | |||
There was a problem hiding this comment.
One weird quirk...I realized after writing this that we don't actually specify that this logic should only fire when the from is clicked on a rental vehicle popup. And yet, when I click the from on other popups (like a stop), it doesn't enable the rental vehicle mode. I'm not really sure why...
| @@ -319,6 +325,23 @@ class DefaultMap extends Component { | |||
| const baseLayerUrls = baseLayersWithNames?.map((bl) => bl.url) | |||
| const baseLayerNames = baseLayersWithNames?.map((bl) => bl.name) | |||
|
|
|||
| const overlayTypes = overlays | |||
| ?.filter((overlay) => overlay?.type === 'otp2')?.[0] | |||
There was a problem hiding this comment.
Could we not use find instead?
| const overlayTypes = overlays | ||
| ?.filter((overlay) => overlay?.type === 'otp2')?.[0] | ||
| ?.layers?.map((layer) => layer?.type) | ||
| const handleSetLocation = (location: MapLocationActionArg) => { |
There was a problem hiding this comment.
This is one approach, but could we not fix this by adjusting query params? What if we check for map state in the places where query params are set? Might that be a better separation of concerns than setting modes within the map component?
| @@ -486,6 +509,7 @@ const mapStateToProps = (state) => { | |||
| bikeRentalStations: state.otp.overlay.bikeRental.stations, | |||
| carRentalStations: state.otp.overlay.carRental.stations, | |||
| config: state.otp.config, | |||
| currentQuery: state.otp.currentQuery, | |||
There was a problem hiding this comment.
Not a huge fan of importing query info into the map component...
Description:
This PR adds functionality to automatically select the rental vehicle mode in the trip planner when starting a trip from a selected rental vehicle in Nearby View. The logic respects the existing trip modes that are selected.
PR Checklist: