Skip to content

Vehicle rental overlay graphql migration #1440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 30 commits into
base: dev
Choose a base branch
from
Draft

Vehicle rental overlay graphql migration #1440

wants to merge 30 commits into from

Conversation

alec-georgoff
Copy link
Collaborator

Description:

This PR updates the bikeRentalQuery to use graphQL instead of the deprecated REST endpoint.

Note that the updates to OTP-UI found in this PR must be merged to correctly use the response that comes back from graphQL.

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

binh-dam-ibigroup and others added 28 commits July 8, 2025 09:43
@binh-dam-ibigroup
chore(deps): Upgrade maplibre-gl and react-map-gl. Fix imports.
7d35c98
@binh-dam-ibigroup
refactor(getFitBoundsPadding): Import from OTP-UI base-map ESM
d961b64
@binh-dam-ibigroup
refactor: Update imports for react-map-gl
d2f2d22
@binh-dam-ibigroup
chore(deps): Use OTP-UI test packages
1d4090a
@binh-dam-ibigroup
chore(deps): Use tmp dependencies for test
0a4de65
@miles-grant-ibigroup
upgrade trip-form
636d740
@alec-georgoff
Move bike rental query to graphQL
3c4a12c
@alec-georgoff
Update bike rental response reducer
95a31c5
@alec-georgoff
Remove comment
5f66024
@binh-dam-ibigroup
chore(deps): Update OTP-UI trip-form
175b0ea
@binh-dam-ibigroup
fix(ResponsiveWebApp): Sort from/to coordinates before calling map.fi…
f4d84e1 
…tBounds()
@binh-dam-ibigroup
fix(RoutePreviewOverlay): Sort coordinates before calling map.fitBounds
3be3901
@binh-dam-ibigroup
refactor(webapp,rtprvw): Extract method to fit map to endpoints
b42f5ae
@binh-dam-ibigroup
refactor(RoutePreviewOverlay): Improve typing
12ef610
@binh-dam-ibigroup
refactor(RoutePreviewOverlay): Remove console statement
1e70eef
@alec-georgoff
Update car rental query and consolidate rental vehicle query logic
814d420
@alec-georgoff
Fix carRentalQuery
915413f
@alec-georgoff
Merge remote-tracking branch 'origin/dev' into vehicle-rental-overlay…
e9bb584 
…-graphql-migration
@binh-dam-ibigroup
chore(deps): Update maplibre to 5.6.1
52a30fe
@binh-dam-ibigroup
refactor(util): Reuse fitMapToPoints with bounds sorting from base-map.
55b77a4
@binh-dam-ibigroup
Merge branch 'dev' into new-maplibre-nopublish
991f56d
@binh-dam-ibigroup
chore(deps): Finish updating maplibre to 5.6.1.
84b55f0
@binh-dam-ibigroup
fix(NearbyView): Throttle mouseleave events (Firefox bug)
6fe7dd6
@alec-georgoff
Update vehicle rental queries to use graphQL and new types
d5f97ea
@alec-georgoff
Merge remote-tracking branch 'origin/dev' into vehicle-rental-overlay…
b3cf826 
…-graphql-migration
@binh-dam-ibigroup
Merge branch 'dev' into new-maplibre-nopublish
5779115
@alec-georgoff
Merge remote-tracking branch 'origin/new-maplibre-nopublish' into veh…
8511d5c 
…icle-rental-overlay-graphql-migration
@alec-georgoff
Merge remote-tracking branch 'origin/dev' into vehicle-rental-overlay…
a57cd26 
…-graphql-migration
@alec-georgoff alec-georgoff marked this pull request as draft August 7, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alec-georgoff @binh-dam-ibigroup @miles-grant-ibigroup