Skip to content

Conversation

leonardehrenfried
Copy link
Member

@leonardehrenfried leonardehrenfried commented Aug 29, 2025

Summary

It allows deployments to use fares v1 as well as v2.

During graph build we find out if a feed contains both then use v2, otherwise use v1. This means that feed A's v1 data can be combined with feed B's v2, even in the same itinerary.

Unit tests

Added.

Documentation

Javadoc.

Changelog

No, sandbox feature.

cc @miles-grant-ibigroup @fpurcell

Copy link

codecov bot commented Aug 29, 2025

Codecov Report

❌ Patch coverage is 86.36364% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.01%. Comparing base (1c8fdcb) to head (6733196).

Files with missing lines Patch % Lines
...pplanner/ext/fares/impl/gtfs/GtfsFaresService.java 80.00% 1 Missing and 1 partial ⚠️
...er/gtfs/mapping/GTFSToOtpTransitServiceMapper.java 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             dev-2.x    #6836   +/-   ##
==========================================
  Coverage      72.00%   72.01%           
- Complexity     19430    19431    +1     
==========================================
  Files           2099     2099           
  Lines          78730    78738    +8     
  Branches        7961     7962    +1     
==========================================
+ Hits           56692    56705   +13     
+ Misses         19233    19227    -6     
- Partials        2805     2806    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants