Skip to content

Add tracing tags for headers and query parameters to GTFS API #6712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

VillePihlava
Copy link
Contributor

@VillePihlava VillePihlava commented Jun 23, 2025

Summary

This PR adds the ability to configure tracing tags for headers and query parameters in the GTFS API. This is enabled with a router config field.

Issue

N/A

Unit tests

Small changes to existing unit tests

Documentation

Javadoc and other documentation added

@VillePihlava VillePihlava requested a review from a team as a code owner June 23, 2025 12:41
@VillePihlava
Copy link
Contributor Author

In tomorrows dev meeting we should discuss if the header and query parameter tags should come from the same config field or be separate.

Copy link

codecov bot commented Jun 23, 2025

Codecov Report

Attention: Patch coverage is 28.57143% with 35 lines in your changes missing coverage. Please review.

Project coverage is 71.77%. Comparing base (4738e85) to head (b4de1da).
Report is 29 commits behind head on dev-2.x.

Files with missing lines Patch % Lines
...org/opentripplanner/apis/support/TracingUtils.java 0.00% 18 Missing ⚠️
.../org/opentripplanner/apis/gtfs/GtfsGraphQLAPI.java 0.00% 12 Missing ⚠️
...opentripplanner/apis/transmodel/TransmodelAPI.java 0.00% 2 Missing ⚠️
...anner/standalone/config/sandbox/GtfsApiConfig.java 91.66% 1 Missing ⚠️
...andalone/configure/ConstructApplicationModule.java 0.00% 1 Missing ⚠️
...standalone/server/DefaultServerRequestContext.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             dev-2.x    #6712      +/-   ##
=============================================
- Coverage      71.78%   71.77%   -0.02%     
- Complexity     19061    19065       +4     
=============================================
  Files           2064     2066       +2     
  Lines          77679    77713      +34     
  Branches        7919     7921       +2     
=============================================
+ Hits           55759    55775      +16     
- Misses         19099    19119      +20     
+ Partials        2821     2819       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@VillePihlava VillePihlava added GTFS Related to import of GTFS data Sandbox Config Change HSL Helsinki Regional Transport Authority labels Jun 25, 2025
@VillePihlava VillePihlava merged commit 26029a6 into opentripplanner:dev-2.x Jun 27, 2025
7 checks passed
@VillePihlava VillePihlava deleted the add-tracing-tags-to-gtfs-api branch June 27, 2025 13:23
t2gran pushed a commit that referenced this pull request Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config Change GTFS Related to import of GTFS data HSL Helsinki Regional Transport Authority Sandbox
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants