-
Notifications
You must be signed in to change notification settings - Fork 18
fix(nest.js): add lose migrations #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
fix(nest.js): add lose migrations #142
Conversation
WalkthroughThe pull request updates Docker volume mappings and a Dockerfile VOLUME path to reference Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
template/nestJs/docker-compose.yml(1 hunks)template/nestJs/dockerfile(1 hunks)template/nestJs/endpoint.sh(1 hunks)template/nestJs/migrations/1764502806299-TinyPro.js(1 hunks)
🧰 Additional context used
🪛 Shellcheck (0.11.0)
template/nestJs/endpoint.sh
[error] 1-1: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
(SC2148)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: e2e-test
🔇 Additional comments (2)
template/nestJs/dockerfile (1)
26-26: LGTM! Volume path now aligns with WORKDIR.The updated VOLUME path correctly references
/builder/dist/data, which is consistent with the WORKDIR/builder/set on line 2 and the volume mapping in docker-compose.yml.template/nestJs/docker-compose.yml (1)
33-33: LGTM! Volume mapping now consistent with dockerfile.The updated volume mapping correctly references
/builder/dist/data, fixing the previous inconsistency where it pointed to/APP/dist/datawhile the dockerfile uses/builder/as WORKDIR.
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.