Skip to content

Conversation

@bukepo
Copy link
Member

@bukepo bukepo commented Feb 11, 2025

This commit forbids using "OpenThreadDebug" as the vendor name in production build. This commit also discourages "BorderRouter" as product name in production build.

@bukepo bukepo changed the title [meshcop] do not allow OpenThread vendor name in production build [meshcop] no default vendor name in production build Feb 11, 2025
@bukepo bukepo force-pushed the vendor-name-ot branch 3 times, most recently from 5e83900 to 6a5e2d1 Compare February 12, 2025 02:38
@codecov
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.30%. Comparing base (2b41187) to head (b61e6d7).
Report is 952 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2704       +/-   ##
===========================================
- Coverage   55.77%   43.30%   -12.47%     
===========================================
  Files          87      108       +21     
  Lines        6890    13404     +6514     
  Branches        0      963      +963     
===========================================
+ Hits         3843     5805     +1962     
- Misses       3047     7291     +4244     
- Partials        0      308      +308     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bukepo bukepo force-pushed the vendor-name-ot branch 3 times, most recently from 2611459 to 215adbe Compare February 18, 2025 06:49
@bukepo bukepo changed the title [meshcop] no default vendor name in production build [build] remove default vendor name Feb 18, 2025
@bukepo bukepo force-pushed the vendor-name-ot branch 7 times, most recently from 1cde4c5 to 697f551 Compare February 20, 2025 03:13
@bukepo bukepo requested review from jwhui and morningboata February 20, 2025 04:00

cmake -GNinja -DCMAKE_EXPORT_COMPILE_COMMANDS=ON "${OTBR_TOP_SRCDIR}" "$@"
cmake -GNinja -DCMAKE_EXPORT_COMPILE_COMMANDS=ON \
-DCMAKE_BUILD_TYPE=Debug "${OTBR_TOP_SRCDIR}" "$@"
Copy link
Contributor

@morningboata morningboata Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can we add instruction above (around line 47), on how to compile a Debug version, and how to compile a Release version (with the vendor_name and model name as parameter)?

  2. Local run to ensure both instructions (Debug and Release) works.

  3. if user run command "script/cmake-build -DCMAKE_BUILD_TYPE=Release", the command line parameter "DCMAKE_BUILD_TYPE=Release" will override "-DCMAKE_BUILD_TYPE=Debug" here right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if user run command "script/cmake-build -DCMAKE_BUILD_TYPE=Release", the command line parameter "DCMAKE_BUILD_TYPE=Release" will override "-DCMAKE_BUILD_TYPE=Debug" here right?

Yes.

@bukepo bukepo requested review from jwhui and removed request for jwhui February 21, 2025 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants