Conversation
Signed-off-by: strantalis <[email protected]>
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a valuable feature by allowing a custom SRT (Signed Request Token) signer to be provided to the SDK. The implementation is well-structured, introducing a new SrtSigner interface and a default implementation, and integrating it cleanly into the SDKBuilder and KASClient. The changes also include comprehensive tests for the new functionality.
My review includes a few suggestions to enhance the API design by using more specific exception types, which will improve code clarity and robustness, and a recommendation for improving test code quality. Overall, this is a solid contribution.
X-Test Results✅ go-v0.4.34 |
Signed-off-by: strantalis <[email protected]>
|
X-Test Results✅ go-v0.4.34 |
|
/backport |
|
Backport failed for |
|
/backport |
Signed-off-by: strantalis <[email protected]> (cherry picked from commit f93d332)
|
Successfully created backport PR for |
Signed-off-by: strantalis <[email protected]> (cherry picked from commit f93d332)
2 participants
No description provided.