do not suggest that testing is optional - #2834
Conversation
we have enough pull requests to make testing mandatory for contributors
|
it also has extra bonus that common pattern with auto-generated low effort PRs is lack of followups this makes more clear that closing them if OK (note, this PR is not triggered by any specific recent action - rather by my general approach is that PRs without testing done by author have much lower processing priority so effectively will be never reviewed. I may have closed some already as author refused to do testing, while this description suggests that maintainer will do testing if you refuse. And yes, I have merged some trivial PRs before contributor got chance to do own testing. But we should not promise that) |
|
🍱 Your pull request preview is ready Please use this preview to check your changes. Ideally use the test documentation template and document your test results by commenting on the PR. This will speed up the review process for everyone. Use the Compare View on the Tagging Schema Browser (alpha) to see the changes of your PR against the FYI, once this PR is merged, you can use the iD Editor Preview to test your changes in interaction with all other changes. |
|
@1ec5 hopefully I have not made it rude by US standards... Can you check? |
tordans
left a comment
There was a problem hiding this comment.
I agree we can push this a bit more. I ran a quick LLM pass to tidy the wording. Contributors who aren’t changing presets will understand that this doesn’t apply to them.
Co-authored-by: Tobias <t@tobiasjordans.de>
Co-authored-by: Tobias <t@tobiasjordans.de>
this is not strictly speaking documentation and phrase it as finishing PR rather than extra work on top of making PR
| <details><summary>Read about the necessary next steps…</summary> | ||
|
|
||
| Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it. | ||
| We need your help testing your change. Please follow the steps below to finish pull request by testing new presets. |
There was a problem hiding this comment.
| We need your help testing your change. Please follow the steps below to finish pull request by testing new presets. | |
| We need your help testing your change. Please follow the steps below to complete your pull request by testing new presets. |
🤷
Description, Motivation & Context
we have enough pull requests to make testing mandatory for contributors
Related issues
just look at https://github.com/openstreetmap/id-tagging-schema/pulls?q=is%3Apr :)
current phrasing may mislead contributors into thinking into that it is optional
Links and data
Relevant OSM Wiki links:
Relevant tag usage stats:
Checklist and Test-Documentation Template
Read on to get your PR merged faster…
Follow these steps to test your PR yourself and make it a lot easier and faster for maintainers to check and approve it.
This is how it works:
After you submit your PR, the system will create a preview and comment on your PR:
Once the preview is ready, use it to test your changes.
Now copy the snippet below into a new comment and fill out the blanks.
Now your PR is ready to be reviewed.