Skip to content

Fix: Ctrl+Shift+I should not trigger Ctrl+I#12136

Open
ahir-u wants to merge 1 commit intoopenstreetmap:developfrom
ahir-u:develop
Open

Fix: Ctrl+Shift+I should not trigger Ctrl+I#12136
ahir-u wants to merge 1 commit intoopenstreetmap:developfrom
ahir-u:develop

Conversation

@ahir-u
Copy link
Copy Markdown

@ahir-u ahir-u commented Mar 29, 2026

This fixes an issue where shortcuts that do not require Shift (e.g. Ctrl+I) are still triggered when Shift is pressed. This bug does not happen on Max (with cmnd).

Fix

Always enforce exact matching of the shift modifier.

Result

  • It explicitly checks for the status of Shift to match (both false and true)
  • Ctrl+I no longer triggers on Ctrl+Shift+I
  • Shift-specific shortcuts still work
  • Caps Lock behavior unaffected

Fixes #10817

@matkoniecz
Copy link
Copy Markdown
Contributor

CI logs:

 ❯ test/spec/util/keybinding.js (10 tests | 1 failed) 16ms
       ✓ returns self 2ms
       ✓ adds a binding for the specified bare key 2ms
       ✓ adds a binding for the specified key combination 1ms
       × matches the binding even when shift is present 8ms

either it is bug in the main code that needs to be fixed or it is bug in tests

@matkoniecz
Copy link
Copy Markdown
Contributor

@ahir-u Do you plan to finish it?

@ahir-u
Copy link
Copy Markdown
Author

ahir-u commented Apr 16, 2026

Yes, didn't have time for it yet. I am a little confused, it should be this way:
Shift + I = I
Shift + Ctrl + I ≠ Ctrl + I
correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CTRL+SHIFT+I should not trigger CTRL+I

2 participants