Fix: Ctrl+Shift+I should not trigger Ctrl+I#12136
Open
ahir-u wants to merge 1 commit intoopenstreetmap:developfrom
Open
Fix: Ctrl+Shift+I should not trigger Ctrl+I#12136ahir-u wants to merge 1 commit intoopenstreetmap:developfrom
ahir-u wants to merge 1 commit intoopenstreetmap:developfrom
Conversation
Contributor
|
CI logs: either it is bug in the main code that needs to be fixed or it is bug in tests |
Contributor
|
@ahir-u Do you plan to finish it? |
Author
|
Yes, didn't have time for it yet. I am a little confused, it should be this way: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue where shortcuts that do not require Shift (e.g. Ctrl+I) are still triggered when Shift is pressed. This bug does not happen on Max (with cmnd).
Fix
Always enforce exact matching of the shift modifier.
Result
Fixes #10817