CORE-1035 - customizable folio #413
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #413 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 217 219 +2
Lines 3603 3681 +78
=========================================
+ Hits 3603 3681 +78
🚀 New features to boost your workflow:
|
TylerZeroMaster
force-pushed
the
core-1035-customizable-folio
branch
from
b311cbb to
17393db
Compare
TylerZeroMaster
force-pushed
the
core-1035-customizable-folio
branch
from
17393db to
bd36b8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://openstax.atlassian.net/browse/CORE-1035
One part of the folio for algebra-1. This new version of
BakeFoliois very similar to the old version except it will not include the separator if the number is missing (unnumbered unit/chapter) and it gets the number out of the title instead of trying to generate it.For algebra-1 at least, this approach works better. Another difference is that
v2only supports the "new approach" to the folio. This becomes relevant when looking at the style changes in ce-styles PR. In short, the old folio was automatically generated purely in CSS. This new one can be generated in cookbook which is good for cases like this where I need to conditionally have different text.As for the fix to chapter titles... I don't think this should affect the web build at all. I am pretty sure the web version ignores the chapter titles.