Skip to content

Core 1123 fix question styling #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2025
Merged

Core 1123 fix question styling #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c157667
Remove extra padding
RoyEJohnson Sep 3, 2025
8e2c251
Uppercase question info section
RoyEJohnson Sep 3, 2025
c2963e7
Update snapshots
RoyEJohnson Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ export const InnerStepCard = styled.div`
display: flex;
flex-direction: column;
flex: 1 1 auto;
min-height: 400px;
margin: 0 auto 5rem auto;
border: 0.1rem solid ${colors.palette.pale};
border-radius: 0.25rem;
Expand Down Expand Up @@ -44,6 +43,7 @@ const StepCardHeader = styled.div`
align-items: baseline;
font-size: inherit;
margin: inherit;
text-transform: uppercase;

.question-id {
font-weight: normal;
Expand Down
1 change: 1 addition & 0 deletions src/components/FreeResponseInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ const StyledFreeResponse = styled.div`

.step-card-body {
${mixins.stepCardPadding()}
padding-bottom: 1rem;
}
`;

Expand Down
30 changes: 15 additions & 15 deletions src/components/__snapshots__/Card.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@ exports[`StepCard matches snapshot 1`] = `
className="sc-gsnTZi dxdISE"
>
<div
className="sc-bczRLJ eurzkp"
className="sc-bczRLJ fZGYwW"
>
<div>
<div
id="step-card"
>
<div
className="sc-dkzDqf eYRLRg step-card-header"
className="sc-dkzDqf jPjFCZ step-card-header"
>
<div>
<h2
Expand Down Expand Up @@ -43,7 +43,7 @@ exports[`StepCard matches snapshot 1`] = `
</div>
</div>
<div
className="sc-hKMtZM bwRTaS"
className="sc-hKMtZM dCUIYQ"
>
Question content
</div>
Expand All @@ -58,14 +58,14 @@ exports[`StepCard matches snapshot with more than one question 1`] = `
className="sc-gsnTZi dxdISE"
>
<div
className="sc-bczRLJ eurzkp"
className="sc-bczRLJ fZGYwW"
>
<div>
<div
id="step-card"
>
<div
className="sc-dkzDqf eYRLRg step-card-header"
className="sc-dkzDqf jPjFCZ step-card-header"
>
<div>
<h2
Expand Down Expand Up @@ -102,7 +102,7 @@ exports[`StepCard matches snapshot with more than one question 1`] = `
</div>
</div>
<div
className="sc-hKMtZM bwRTaS"
className="sc-hKMtZM dCUIYQ"
>
Question content
</div>
Expand All @@ -118,14 +118,14 @@ exports[`TaskStepCard can optionally provide task 1`] = `
data-task-step-id={1}
>
<div
className="sc-bczRLJ eurzkp exercise-step"
className="sc-bczRLJ fZGYwW exercise-step"
>
<div>
<div
id="step-card"
>
<div
className="sc-dkzDqf eYRLRg step-card-header"
className="sc-dkzDqf jPjFCZ step-card-header"
>
<div>
<h2
Expand All @@ -149,7 +149,7 @@ exports[`TaskStepCard can optionally provide task 1`] = `
</div>
</div>
<div
className="sc-hKMtZM bwRTaS"
className="sc-hKMtZM dCUIYQ"
/>
</div>
</div>
Expand All @@ -163,14 +163,14 @@ exports[`TaskStepCard can optionally provide type 1`] = `
data-task-step-id={1}
>
<div
className="sc-bczRLJ eurzkp exercise-step"
className="sc-bczRLJ fZGYwW exercise-step"
>
<div>
<div
id="step-card"
>
<div
className="sc-dkzDqf eYRLRg step-card-header"
className="sc-dkzDqf jPjFCZ step-card-header"
>
<div>
<h2
Expand All @@ -194,7 +194,7 @@ exports[`TaskStepCard can optionally provide type 1`] = `
</div>
</div>
<div
className="sc-hKMtZM bwRTaS"
className="sc-hKMtZM dCUIYQ"
/>
</div>
</div>
Expand All @@ -208,14 +208,14 @@ exports[`TaskStepCard matches snapshot 1`] = `
data-task-step-id={1}
>
<div
className="sc-bczRLJ eurzkp exercise-step"
className="sc-bczRLJ fZGYwW exercise-step"
>
<div>
<div
id="step-card"
>
<div
className="sc-dkzDqf eYRLRg step-card-header"
className="sc-dkzDqf jPjFCZ step-card-header"
>
<div>
<h2
Expand All @@ -239,7 +239,7 @@ exports[`TaskStepCard matches snapshot 1`] = `
</div>
</div>
<div
className="sc-hKMtZM bwRTaS"
className="sc-hKMtZM dCUIYQ"
/>
</div>
</div>
Expand Down
6 changes: 3 additions & 3 deletions src/components/__snapshots__/CompletionStatus.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`CompletionStatus matches snapshot 1`] = `
<div
className="sc-bczRLJ sc-gKXOVf eurzkp hSbqXj sc-ftvSup"
className="sc-bczRLJ sc-gKXOVf fZGYwW hSbqXj sc-ftvSup"
>
<h2
className="sc-iBkjds jcQjIn"
Expand All @@ -24,7 +24,7 @@ exports[`CompletionStatus matches snapshot 1`] = `

exports[`CompletionStatus matches snapshot with all questions completed 1`] = `
<div
className="sc-bczRLJ sc-gKXOVf eurzkp hSbqXj sc-ftvSup"
className="sc-bczRLJ sc-gKXOVf fZGYwW hSbqXj sc-ftvSup"
>
<h2
className="sc-iBkjds jcQjIn"
Expand All @@ -46,7 +46,7 @@ exports[`CompletionStatus matches snapshot with all questions completed 1`] = `

exports[`CompletionStatus matches snapshot with some questions completed 1`] = `
<div
className="sc-bczRLJ sc-gKXOVf eurzkp hSbqXj sc-ftvSup"
className="sc-bczRLJ sc-gKXOVf fZGYwW hSbqXj sc-ftvSup"
>
<h2
className="sc-iBkjds jcQjIn"
Expand Down
Loading