Automatically set s3_store_cacert when S3 and TLS are enabled #802
Conversation
fmount
requested review from
konan-abhi
and removed request for
dprince and
fultonj
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/lib-common#641 is needed. |
konan-abhi
left a comment
konan-abhi
left a comment
There was a problem hiding this comment.
Thank you for explaining in detail, looks good to me!!!
|
This change depends on a change that failed to merge. Change openstack-k8s-operators/lib-common#641 is needed. |
Add automatic S3 CA certificate injection when TLS is enabled, injecting s3_store_cacert parameter to point to the CA bundle. It is based on the mechanism via lib-common util.ExtendCustomServiceConfig() that safely adds configuration options without overwriting existing user settings, preserving customServiceConfig integrity based on user input. Jira: https://issues.redhat.com/browse/OSPRH-14309 Signed-off-by: Francesco Pantano <[email protected]>
konan-abhi
left a comment
konan-abhi
left a comment
There was a problem hiding this comment.
Looks good, thank you!!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount, konan-abhi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@fmount: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test glance-operator-build-kuttl |
3 participants
Add automatic
S3CAcertificate injection whenTLSis enabled, injectings3_store_cacertparameter to point to the CA bundle. This is based on the mechanism provided bylib-commonutil.ExtendCustomServiceConfig()that safely adds configuration options without overwriting existing user settings, preservingcustomServiceConfigintegrity based on the user input.Jira: https://issues.redhat.com/browse/OSPRH-14309