fix(approve-installplan): drop unused openstacks RBAC rule

[oliashish]

The Job no longer reads operator.openstack.org/openstacks, so remove the stale get/list grant from installplan-approver-role.

Jira: OSPRH-33125

Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: c343735c-dfd4-4aab-af96-1d000f1471d1

📥 Commits

Reviewing files that changed from the base of the PR and between d5a4523 and 4db0ca9.

📒 Files selected for processing (1)

• components/utilities/approve-installplan/rbac.yaml

💤 Files with no reviewable changes (1)

• components/utilities/approve-installplan/rbac.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

📝 Walkthrough

Summary by CodeRabbit

• Chores
  • Removed unnecessary permissions for OpenStack resources.
  • Existing permissions for OpenStack version information remain unchanged.

Walkthrough

The approve-installplan ClusterRole no longer grants get and list access to operator.openstack.org openstacks resources. Access to core.openstack.org openstackversions remains unchanged.

Changes

ApproveInstallPlan RBAC

Layer / File(s)	Summary
Remove openstacks permissions components/utilities/approve-installplan/rbac.yaml	The ClusterRole no longer grants get and list access to operator.openstack.org openstacks resources.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 4db0c

This change removes an unused permission from the install-plan approval role. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies removal of the unused OpenStack RBAC rule.
Description check	✅ Passed	The description explains that stale get/list permissions are removed because the Job no longer reads the resource.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}