fix(approve-installplan): cache InstallPlan query and retry on version mismatch - #101
Merged
cjeanner merged 1 commit intoAug 18, 2026
Conversation
cjeanner
approved these changes
Aug 18, 2026
cjeanner
left a comment
Collaborator
There was a problem hiding this comment.
Looks OK. There were some testing on the side, since we don't have CI capabilities to test that specific kind of changes. Reports were green.
- Fetch InstallPlans once per iteration and run all jq filters against that cached snapshot: fewer API calls and one consistent view per iteration. - Don't exit on a newer-than-pinned plan (OLM catalog resolution is eventually consistent); warn and retry, failing only once retries are exhausted. The version gate is preserved: a wrong-version plan is never approved. Jira: OSPRH-33123, OSPRH-33124 Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
oliashish
force-pushed
the
fix/installplan-cache-and-retry
branch
from
August 18, 2026 15:15
18b5c59 to
45cb3a2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cached snapshot: fewer API calls and one consistent view per iteration.
consistent); warn and retry, failing only once retries are exhausted. The
version gate is preserved: a wrong-version plan is never approved.
Tested them locally by
Jira: OSPRH-33123, OSPRH-33124
Co-Authored-By: Claude Opus 4.8 noreply@anthropic.com