[reproducer] Refresh premetal config vars from resolved hostvars#4021
[reproducer] Refresh premetal config vars from resolved hostvars#4021michburk wants to merge 1 commit into
Conversation
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
In premetal deployments, config variables updated between bootstrap and pickup were not reflected in reproducer-variables.yml. Merge the hypervisor's filtered hostvars over the existing bootstrap dump so new/changed values win while bootstrap-time state is preserved. Generated-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Michael Burke <michburk@redhat.com>
michburk
force-pushed
the
premetal-config-vars-v2
branch
from
94a2d45 to
24be294
Compare
| - name: Overwrite custom-params.yml | ||
| - name: Write merged custom-params.yml to controller-0 | ||
| vars: | ||
| _merged: >- |
There was a problem hiding this comment.
(non-blocking) suggestion: I think we can move this to the block vars level, as _merged is the same used at L52. So we don't need to calculate it twice.
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
2 participants
In premetal deployments, config variables updated between bootstrap and pickup were not reflected in reproducer-variables.yml. Overwrite it at pickup time by dumping the hypervisor's filtered hostvars using the same filter chain as configure_bm_ocp_controller.yml.