add runbooks for new alerts#363
Conversation
|
@aruniiird @weirdwiz please do have a look. |
9a36696 to
9773226
Compare
alerts/openshift-container-storage-operator/ODFCorePodRestarted.md
Outdated
Show resolved
Hide resolved
alerts/openshift-container-storage-operator/ODFCorePodRestarted.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
no mitigation section? please add mitigation steps,
There was a problem hiding this comment.
I am not sure of what mitigation steps should be added here, so I left it empty for now!!
@weirdwiz if you have any suggestions, we can discuss offline.
There was a problem hiding this comment.
Mitigation for this is to either move workloads to other storage systems or (preferred) add more disks.
Ceph is one of the few storage systems that grows IO performance linearly with capacity... so more disks = more performance
There was a problem hiding this comment.
same here, add mitigation steps
There was a problem hiding this comment.
The MTU runbook should mention how to verify jumbo frames work end-to-end
There was a problem hiding this comment.
I am not sure about this, maybe we can work on it once you are back.
There was a problem hiding this comment.
You can find many "Jumbo Frame" test instructions on the internet - for example this one:
https://blah.cloud/networks/test-jumbo-frames-working/
In the end you use ping with a certain icmp size (which different for the different OSs) and you tell the network stack not to fragment the package (but send it whole).
As a mitigation, customers need to ensure the node network interfaces are configured for 9000 bytes AND that all switches in between the nodes also support 9000 bytes on their ports.
There was a problem hiding this comment.
existing runbooks reference shared helper documents like:
- helpers/podDebug.md
- helpers/troubleshootCeph.md
- helpers/gatherLogs.md
- helpers/networkConnectivity.md
the new runbooks embed all commands inline instead of referencing these. consider using helper links for consistency and maintainability.
| ping <node-internal-ip> | ||
| ``` | ||
| 4. Use mtr or traceroute to analyze path and hops. | ||
| 5. Verify if the node is under high CPU or network load: |
There was a problem hiding this comment.
| 5. Verify if the node is under high CPU or network load: | |
| 5. Verify if the node is under high CPU or network load: | |
| oc debug node/<node> | |
| top -b -n 1 | head -20 | |
| sar -u 1 5 |
| sar -n DEV 1 5 | ||
| ``` | ||
| 3. Use Prometheus to graph: | ||
| ```prompql |
There was a problem hiding this comment.
| ```prompql | |
| ```promql |
9773226 to
2deb710
Compare
|
@weirdwiz updated the PR except for the 2 comments, we can work on them once you are back. |
2deb710 to
4efb275
Compare
|
|
||
| ## Impact | ||
|
|
||
| * Brief service interruption (e.g., MON restart may cause quorum re-election). |
There was a problem hiding this comment.
service interruption sounds worse than it is... unless the MONs cannot agree to a quorum any more, there is no "downtime".
Instead let's put all of the Impact points in relative points... Since Ceph is very resilient, Pod restarts should only have an affect if they happen frequently (more than 10 times in a 5min window).
| ## Impact | ||
|
|
||
| * Brief service interruption (e.g., MON restart may cause quorum re-election). | ||
| * OSD restart triggers PG peering and potential recovery. |
There was a problem hiding this comment.
Someone who doesn't know Ceph will not understand this :) (even though it is factually correct)
How do you like my proposal:
If OSDs are restarted frequently or do not start up within 5 minutes, the cluster might decide to rebalance the data onto other more reliable disks. If this happens, the cluster will temporarily be slightly less performant.
|
|
||
| ## Impact | ||
|
|
||
| * Increased I/O latency for RBD/CephFS clients. |
There was a problem hiding this comment.
RBD and CephFS are Ceph terms. Let's keep it simple and just call them Block, Object and File (all of these would be affected)
| ## Impact | ||
|
|
||
| * Increased I/O latency for RBD/CephFS clients. | ||
| * Slower OSD response times, risking heartbeat timeouts. |
There was a problem hiding this comment.
I don't think that's true. If the underlying storage is busy, the process should still be able to send heartbeats?!
There was a problem hiding this comment.
Mitigation for this is to either move workloads to other storage systems or (preferred) add more disks.
Ceph is one of the few storage systems that grows IO performance linearly with capacity... so more disks = more performance
| 5. Review Ceph monitor logs if the node hosts MONs: | ||
| ```bash | ||
| oc logs -l app=rook-ceph-mon -n openshift-storage | ||
| ``` |
There was a problem hiding this comment.
Another step could be to check switch / networking monitoring to see if any ports are too busy
| ## Diagnosis | ||
|
|
||
|
|
||
| 1. Identify affected node(s): |
There was a problem hiding this comment.
Why do we have this step if we get the node name and IP in step #2 from the alert?
|
|
||
| ## Mitigation | ||
|
|
||
| 1. Network tuning: Ensure jumbo frames (MTU ≥ 9000) are enabled end-to-end |
There was a problem hiding this comment.
Are you sure Jumbo Frames will help with latency? Why?
There was a problem hiding this comment.
You can find many "Jumbo Frame" test instructions on the internet - for example this one:
https://blah.cloud/networks/test-jumbo-frames-working/
In the end you use ping with a certain icmp size (which different for the different OSs) and you tell the network stack not to fragment the package (but send it whole).
As a mitigation, customers need to ensure the node network interfaces are configured for 9000 bytes AND that all switches in between the nodes also support 9000 bytes on their ports.
|
|
||
| ## Mitigation | ||
|
|
||
| 1. Short term: Throttle non-essential traffic on the node. |
4efb275 to
0f8b761
Compare
0f8b761 to
5ca12a0
Compare
mulbc
left a comment
There was a problem hiding this comment.
lgtm - small error corrections where I added recommendations. Aside from these I'm good with the PR
|
|
||
| * If OSDs are restarted frequently or do not start up within 5 minutes, | ||
| the cluster might decide to rebalance the data onto other more reliable | ||
| disks.If this happens, the cluster will temporarily be slightly less |
There was a problem hiding this comment.
| disks.If this happens, the cluster will temporarily be slightly less | |
| disks. If this happens, the cluster will temporarily be slightly less |
|
|
||
| ## Mitigation | ||
|
|
||
| * Increase more disks to enhance the performance. |
There was a problem hiding this comment.
| * Increase more disks to enhance the performance. | |
| * Add more disks to the cluster to enhance the performance. |
| ## Diagnosis | ||
|
|
||
| 1. From the alert, note the instance (node IP). | ||
| 2. Confirm the node does not run OSDs: |
There was a problem hiding this comment.
If this is an OSD node and triggers the >100ms alert, we're in trouble :P
So I think this check does not provide any value (we're not doing anything with the data we gather with this)
there are new alerts introduced for odf health score calculation. This commit adds runbooks for each of them Signed-off-by: yati1998 <ypadia@redhat.com>
5ca12a0 to
f770989
Compare
|
@weirdwiz please review the PR, I have addressed all the comments. |
|
@agarwal-mudit can you please review the PR, it has been approved by @mulbc and @weirdwiz and all other comments are addressed |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: agarwal-mudit, malayparida2000, mulbc, yati1998 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@yati1998: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
|
||
| ## Meaning | ||
|
|
||
| A core ODF pod (OSD, MON, MGR, ODF operator, or metrics exporter) has |
There was a problem hiding this comment.
Why ODF operator and metrics exporter are considered as the core pods?
| ```bash | ||
| iostat -x 2 5 | ||
| ``` | ||
| 4. Correlate with Ceph: |
There was a problem hiding this comment.
Are they supposed to run these commands on the toolbox pod?
|
|
||
| ## Meaning | ||
|
|
||
| ICMP RTT latency to non-OSD ODF nodes (e.g., MON, MGR, MDS, or client nodes) |
There was a problem hiding this comment.
What are client nodes here? csi client?
|
|
||
| * Delayed Ceph monitor elections or quorum instability. | ||
| * Slower metadata operations in CephFS. | ||
| * Increased latency for CSI controller operations. |
There was a problem hiding this comment.
what about the CSI node operation and csi-addons operations?
|
|
||
| 1. From the alert, note the instance (node IP). | ||
| 2. Test connectivity: | ||
| ```bash |
There was a problem hiding this comment.
from there they are suppose to run these commands?
| 3. Check system load and network interface stats on the node: | ||
| ```bash | ||
| oc debug node/<node-name> | ||
| sar -n DEV 1 5 |
There was a problem hiding this comment.
please add details what is 1 and 5 here and how to get it
| ## Diagnosis | ||
|
|
||
| 1. Check the alert’s instance label to get the node IP. | ||
| 2. From a monitoring or debug pod, test connectivity: |
There was a problem hiding this comment.
can we provide a example command to get the monitoring or debug pod
| top -b -n 1 | head -20 | ||
| sar -u 1 5 | ||
| ``` | ||
| 5. Check Ceph health and OSD status: |
There was a problem hiding this comment.
Is toolbox already enabled or they need to enable it?
|
@yati1998 Please take a look at the concerns Madhu has raised & address them in a follow up PR if possible |
there are new alerts introduced for odf
health score calculation. This commit adds
runbooks for each of them